fix(theme-translations): complete and improve Spanish theme translations #9872
Conversation
Updated Spanish Translations in theme-common.json
|
Hi @4troDev! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
slorber
added
pr: bug fix
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Updated the code to enhance specificity. From `Barra lateral` to `Barra lateral de Documentos` using `Barra lateral ' can be used for both docs and blogs.
|
Ok thanks I don't have an expertise in accessibility so we'll see if anyone complains about those changes |
| "theme.DocSidebarItem.collapseCategoryAriaLabel": "Colapsar categoría de barra lateral '{label}'", | ||
| "theme.DocSidebarItem.expandCategoryAriaLabel": "Ampliar la categoría de la barra lateral '{label}'", |
There was a problem hiding this comment.
I'm not Spanish but that doesn't look good to me. {label} is the name of the category, not the name of the sidebar. Wouldn't it be better to put this placeholder closer to the "categoria" word?
There was a problem hiding this comment.
Not sure it applies to Spanish, but what we have in French:
"theme.DocSidebarItem.collapseCategoryAriaLabel": "Réduire la catégorie '{label}' de la barre latérale",
"theme.DocSidebarItem.expandCategoryAriaLabel": "Développer la catégorie '{label}' de la barre latérale",
There was a problem hiding this comment.
{Label} is a place holder if i change it when there is a Label it won't show up since is not in the code
There was a problem hiding this comment.
nvm i understand now what you mean it should be “Reducir la categoría '{label}' de la barra lateral”,
packages/docusaurus-theme-translations/locales/es/theme-common.json
Outdated
Show resolved
Hide resolved
I've fixed and updated Spanish translations in
theme-common.jsonatpackages/docusaurus-theme-translations/locales/es/. PPre-flight checklist